Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKA: Misc cleanup and enhancements #212207

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Feb 24, 2025

Summary

  • Remove some old paths pointing to packages/kbn-pm (no longer exists).
  • Fix group and visibility for @kbn/streams-app-wrapper-plugin. (done in 🌊 Fix plugin visibility #212210)
  • Update scripts/relocate logic with latest enhancements.
  • Convert @kbn/observability-synthetics-test-data folder name to camel-case (messes up with pre-commit hook).

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Feb 24, 2025
@gsoldevila gsoldevila requested review from a team as code owners February 24, 2025 10:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core changes (relocate package) LGTM

@gsoldevila gsoldevila enabled auto-merge (squash) February 24, 2025 11:37
@gsoldevila gsoldevila merged commit a41badf into elastic:main Feb 24, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13499229805

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.18:
- SKA: Relocate "platform" packages that remain on /packages (#208704)
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- SKA: Relocate "platform" packages that remain on /packages (#208704)
- [scout] enable eslint plugin playwright (#210666)
- Remove dependency date-fns !! (#209539)
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- SKA: Relocate "platform" packages that remain on /packages (#208704)

Manual backport

To create the backport manually run:

node scripts/backport --pr 212207

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 25, 2025
## Summary

* Remove some old paths pointing to `packages/kbn-pm` (no longer
exists).
* ~Fix group and visibility for `@kbn/streams-app-wrapper-plugin`~.
(done in elastic#212210)
* Update `scripts/relocate` logic with latest enhancements.
* Convert `@kbn/observability-synthetics-test-data` folder name to
camel-case (messes up with pre-commit hook).

(cherry picked from commit a41badf)

# Conflicts:
#	package.json
#	packages/kbn-relocate/relocate.ts
#	packages/kbn-relocate/utils/transforms.ts
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 25, 2025
## Summary

* Remove some old paths pointing to `packages/kbn-pm` (no longer
exists).
* ~Fix group and visibility for `@kbn/streams-app-wrapper-plugin`~.
(done in elastic#212210)
* Update `scripts/relocate` logic with latest enhancements.
* Convert `@kbn/observability-synthetics-test-data` folder name to
camel-case (messes up with pre-commit hook).

(cherry picked from commit a41badf)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	packages/kbn-relocate/relocate.ts
#	packages/kbn-relocate/utils/transforms.ts
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 25, 2025
## Summary

* Remove some old paths pointing to `packages/kbn-pm` (no longer
exists).
* ~Fix group and visibility for `@kbn/streams-app-wrapper-plugin`~.
(done in elastic#212210)
* Update `scripts/relocate` logic with latest enhancements.
* Convert `@kbn/observability-synthetics-test-data` folder name to
camel-case (messes up with pre-commit hook).

(cherry picked from commit a41badf)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	packages/kbn-relocate/relocate.ts
#	packages/kbn-relocate/utils/transforms.ts
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.x
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Feb 25, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [SKA: Misc cleanup and enhancements
(#212207)](#212207)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T13:31:00Z","message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Misc cleanup and
enhancements","number":212207,"url":"https://github.com/elastic/kibana/pull/212207","mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212207","number":212207,"mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
gsoldevila added a commit that referenced this pull request Feb 25, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [SKA: Misc cleanup and enhancements
(#212207)](#212207)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T13:31:00Z","message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Misc cleanup and
enhancements","number":212207,"url":"https://github.com/elastic/kibana/pull/212207","mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212207","number":212207,"mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
gsoldevila added a commit that referenced this pull request Feb 25, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [SKA: Misc cleanup and enhancements
(#212207)](#212207)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T13:31:00Z","message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Misc cleanup and
enhancements","number":212207,"url":"https://github.com/elastic/kibana/pull/212207","mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212207","number":212207,"mergeCommit":{"message":"SKA:
Misc cleanup and enhancements (#212207)\n\n## Summary\n\n* Remove some
old paths pointing to `packages/kbn-pm` (no longer\nexists).\n* ~Fix
group and visibility for `@kbn/streams-app-wrapper-plugin`~.\n(done in
https://github.com/elastic/kibana/pull/212210)\n* Update
`scripts/relocate` logic with latest enhancements.\n* Convert
`@kbn/observability-synthetics-test-data` folder name to\ncamel-case
(messes up with pre-commit
hook).","sha":"a41badf96496c81587fca3d56c1c891abeb1a3a9"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants